SQLdirectory query lowercasing #1970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- uppercase will never return a result here Fixes: SIRI-951
- stay consistent with the blob implementations - maybe future usages will also profit from optimized queries Fixes: SIRI-951
bkositza
reviewed
Apr 10, 2024
idlira
approved these changes
Apr 10, 2024
sabieber
approved these changes
Apr 10, 2024
bkositza
approved these changes
Apr 10, 2024
mko-sci
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When querying for the lowercased filename field of an directory, query terms containing upper case characters make no sense and will be lower cased.
Note: For MongoDB no changes are required, as it already works due to case insensitive prefix queries.
Additional Notes
Checklist